-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
"extends": "eslint:recommended", | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:react/recommended" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make ESLint understand React specifics. We can configure it further later (see doc).
@@ -85,7 +93,8 @@ | |||
"no-var": "error", | |||
"eqeqeq": "error", | |||
"object-curly-spacing": ["error", "always"], | |||
"object-shorthand": "error" | |||
"object-shorthand": "error", | |||
"react/prop-types": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just disable warning for props used without prop-types declaration, because we don't use it yet. https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prop-types.md
@@ -3,6 +3,7 @@ | |||
module.exports = function(mode) { | |||
const plugins = [ | |||
'@babel/plugin-syntax-dynamic-import', | |||
'@babel/plugin-proposal-class-properties', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not strictly related to React, but this allows to use simplified ES class syntax, which is handy for state, static properties and autobound methods. See this article for examples.
Description
Install the minimal React setup for our toolset.
As React is not imported yet in any code, this doesn't change what's built.
Why
Prepare things to start migrating stuff.