This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Install React #346
Merged
Install React #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
commented
Aug 21, 2019
| "extends": "eslint:recommended", | ||
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:react/recommended" |
There was a problem hiding this comment.
This is to make ESLint understand React specifics. We can configure it further later (see doc).
| @@ -85,7 +93,8 @@ | |||
| "no-var": "error", | |||
| "eqeqeq": "error", | |||
| "object-curly-spacing": ["error", "always"], | |||
| "object-shorthand": "error" | |||
| "object-shorthand": "error", | |||
| "react/prop-types": 0 | |||
There was a problem hiding this comment.
We just disable warning for props used without prop-types declaration, because we don't use it yet. https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prop-types.md
| @@ -3,6 +3,7 @@ | |||
| module.exports = function(mode) { | |||
| const plugins = [ | |||
| '@babel/plugin-syntax-dynamic-import', | |||
| '@babel/plugin-proposal-class-properties', | |||
There was a problem hiding this comment.
This is not strictly related to React, but this allows to use simplified ES class syntax, which is handy for state, static properties and autobound methods. See this article for examples.
Closed
GuillaumeGomez
approved these changes
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Install the minimal React setup for our toolset.
As React is not imported yet in any code, this doesn't change what's built.
Why
Prepare things to start migrating stuff.