This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
[Clean up] Route summary #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
force-pushed
the
clean-up-route-css
branch
from
07721d5
to
94e5c69
Compare
amatissart
approved these changes
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove some dead code in the route result rendering and make CSS more simpler and robust with flex instead of float/absolute positioning.
Why
Let's simplify things a bit before integrating public transports.
And it's great to get rid of all these floats, absolute and magic numbers.
Screens
No big changes, and things are better positioned and spaced (and it works great on IE11).