This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Better handling of buttons position in mobile view #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
reviewed
Aug 22, 2019
There was a problem hiding this comment.
This solution looks a bit hackish to me.
I would prefer to find a way to remove dynamic css completely.
Or at least, we should try to refactor how these buttons are positioned all over the application.
Some css classes are already updated dynamically on buttons in road_map_panel.js and direction_panel.js.
This change should be a opportunity to handle that in a single place.
Anyway, I would wait for @bbecquet's opinion.
src/main.js
Outdated
| el.styleSheet.cssText = css; | ||
| } else { | ||
| el.appendChild(document.createTextNode(css)); | ||
| } |
There was a problem hiding this comment.
this looks very complicated.
Why not el.innerHTML = css ?
GuillaumeGomez
force-pushed
the
location-button-pos
branch
from
e03df5b
to
cb4b1a2
Compare
|
Implemented by #365 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.