This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Improve formatting of route distance/duration #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
force-pushed
the
route-data-formatting
branch
3 times, most recently
from
af70eb9
to
9a3b13d
Compare
|
|
||
| export function formatDuration(sec) { | ||
| sec = Math.max(60, sec); // For duration < 60s, return '1 min' | ||
| let min = Math.round(sec / 60); |
There was a problem hiding this comment.
I'm surprised eslint didn't say that it should be const.
There was a problem hiding this comment.
Oh nevermind. Didn't see below. :)
bbecquet
force-pushed
the
route-data-formatting
branch
from
9a3b13d
to
7445a55
Compare
| if (m > 99000) { | ||
| return `${Math.round(m / 1000)} km`; | ||
| } | ||
| if (m > 1000) { |
There was a problem hiding this comment.
We had a debate about this but I still prefer using else if in such cases. But you can completely ignore this comment.
There was a problem hiding this comment.
Seriously, this pyramid was ridiculous…
if (m > 5) {
if (m > 1000) {
if (m > 99000) {
There was a problem hiding this comment.
That wasn't my point. I didn't like that pyramid either.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
Improve legibility with respect to common typographic rules.
We should actually do that depending on the locale, but let's improve it later, this fixes most cases.
Test suite