Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Fix 'null' strings on symbol layer for POIs with no name #808

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

bbecquet
Copy link
Contributor

@bbecquet bbecquet commented Sep 29, 2020

Description

Fix POIs with no name displayed with a "null" label on the symbol layer.
For that, use the Mapbox-GL ['get', 'name'] expression instead of the "token syntax" {'name'}, which seems to do a toString under the hood.

Note: this brace-based syntax is undocumented and actually appears to be deprecated mapbox/mapbox-gl-js#6216. We should probably replace it by expressions everywhere in our style, but let's discuss that separately.

Screenshots

Before After
Capture d’écran 2020-09-29 à 10 14 17 Capture d’écran 2020-09-29 à 10 13 50

@bbecquet bbecquet added the bug Something isn't working label Sep 29, 2020
@bbecquet bbecquet merged commit e7f71c9 into Qwant:master Sep 29, 2020
@bbecquet bbecquet deleted the fix-null-name branch September 29, 2020 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants