This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
add endpoint search
#224
Merged
add endpoint search
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
reviewed
Apr 27, 2021
remi-dupre
force-pushed
the
search-endpoint
branch
from
078c2c1
to
6d9041f
Compare
amatissart
reviewed
Apr 29, 2021
remi-dupre
force-pushed
the
search-endpoint
branch
from
0bb790e
to
c9eb79c
Compare
amatissart
reviewed
Apr 29, 2021
amatissart
reviewed
May 3, 2021
idunn/api/urls.py
Outdated
Comment on lines
78
to
82
| APIRoute( | ||
| "/search", | ||
| search, | ||
| response_model=IdunnAutocomplete, | ||
| ), |
There was a problem hiding this comment.
For consistency with "/autocomplete", methods and response_model_exclude_unset should be defined too.
There was a problem hiding this comment.
... and we should allow to provide extra parameters through POST queries 👍
idunn/api/search.py
Outdated
| """ | ||
| query.q = normalize(query.q) | ||
|
|
||
| if query.lang in nlu_allowed_languages: |
There was a problem hiding this comment.
Suggested change
| if query.lang in nlu_allowed_languages: | |
| if query.nlu and query.lang in nlu_allowed_languages: |
There was a problem hiding this comment.
We also want to keep this option overridden by AUTOCOMPLETE_NLU_SHADOW_ENABLED, right?
There was a problem hiding this comment.
Well, this option has never been actually used, and is probably not very useful now that the nlu=true is used by the application in most cases.
So I think this flag AUTOCOMPLETE_NLU_SHADOW_ENABLED can be ignored for /search.
remi-dupre
force-pushed
the
search-endpoint
branch
from
8d8c527
to
e410d04
Compare
remi-dupre
force-pushed
the
search-endpoint
branch
from
c5a5a99
to
5cdc530
Compare
amatissart
approved these changes
May 3, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly reuses code from
instant_answerbut I tried to change the API a bit to be more consistent with what we usually use internally between erdapfel and Idunn:get_place(through keyplace) or the format ofget_bbox_places(through keybbox_places)The only slight behavior change is that there is no truncating of the input query, maybe we should add a global parameter for this? I've also thought about skipping normalization since it would seem weird to "ignore or change part of what is in the search bar" but this seems like a free potential improvement of results?
Part of the logs may be weird with the current state of the branch, I'm still thinking there may be some global pattern that could be built since fetching the context from the logger is a common issue we have (eg. how we build extra infos in
nlu_clientor in this case understanding what endpoint is currently being used).