Skip to content

Commit

Permalink
update_city_point: replace ne.gn_ascii join with ne.name_en
Browse files Browse the repository at this point in the history
Here "gn" appears to refer to GeoNames.org as a source. The fields field
`gn_ascii` was deprecated and finally removed in 2021:
nvkelso/natural-earth-vector#477

The deprecation issue recommends to replace the removed field with the
use of `name` (already used) and `name_alts` (which I assume refers to
local variants `name_fr`, `name_en`, ...), so I've included a check on
the English column.
  • Loading branch information
remi-dupre committed Jul 28, 2022
1 parent 65e2f01 commit 507cee8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions layers/place/update_city_point.sql
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ BEGIN
ne.name ILIKE osm.name_en OR
ne.namealt ILIKE osm.name OR
ne.namealt ILIKE osm.name_en OR
ne.name_en ILIKE osm.name OR
ne.name_en ILIKE osm.name_en OR
ne.meganame ILIKE osm.name OR
ne.meganame ILIKE osm.name_en OR
ne.gn_ascii ILIKE osm.name OR
ne.gn_ascii ILIKE osm.name_en OR
ne.nameascii ILIKE osm.name OR
ne.nameascii ILIKE osm.name_en OR
ne.name = unaccent(osm.name)
Expand Down Expand Up @@ -84,4 +84,4 @@ CREATE CONSTRAINT TRIGGER trigger_refresh
AFTER INSERT ON place_city.updates
INITIALLY DEFERRED
FOR EACH ROW
EXECUTE PROCEDURE place_city.refresh();
EXECUTE PROCEDURE place_city.refresh();

0 comments on commit 507cee8

Please sign in to comment.