update_city_point: replace ne.gn_ascii join with ne.name_en #43
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here "gn" appears to refer to GeoNames.org as a source. The fields field
gn_ascii
was deprecated and finally removed in 2021:nvkelso/natural-earth-vector#477
The deprecation issue recommends to replace the removed field with the
use of
name
(already used) andname_alts
(which I assume refers tolocal variants
name_fr
,name_en
, ...), so I've included a check onthe English column.
(Note that is probably a temporary fix until we upgrade our openmaptile fork to a more recent version)