This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
merge master #7
Merged
merge master #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NT. Trying out how webpack plays with env vars * NT. Test run before merge * NT. POC kinda ok for me now * NT. Updated the lc version to released one. * NT. Reverting test data. Ready for PR * NT. Fixing linting. * NT. Fixing the email hash scenario.
* Eplanning: new optional parameter is added * Eplanning: new prioritization metric for adunit sizes * Eplanning: desktop prioritization test for adunit sizes
* support TCFv2.0 * support coppa * support Publisher Domain * support meta.mediaType and meta.advertiserDomains * test parameters for validating bids Co-authored-by: root <root@ubuntu.members.linode.com> Co-authored-by: Ryan Chou <ryanchou0210@gmail.com> Co-authored-by: jack.hsieh <moonnight8520@gmail.com>
* pass GDPR consent data in dfpVideoUrl and dfpAdpodVideoUrl * Send gdpr param as a number Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
* TE Medya Prebid Adapter Hello @aleksatr , We have completed the prebid adapter development for our TE Medya advertisement panel. We ran the tests and checked that it works. I request your review. Best. * Create temedyaBidAdapter_spec.js * Update temedyaBidAdapter_spec.js * Update temedyaBidAdapter_spec.js * Update temedyaBidAdapter_spec.js
…ability with our api (#6169)
Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com>
* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space
…6124) * Add the root domain check method as a global method added for use modules * Add a date suffix to keep the test cookie random * Per review, moved the findRootDomain method to utils out of the userId modules * More the domain method back the user module but attach it to the submodule so that userId modules can have access to it * Remove the storageManager as it is no longer used in utils
* add mediaforce bid adapter * make use of unused variable language * Added native support for Mediaforce Bid Adapter * Fix test endpoint url for Mediaforce Bid Adapter * cleanup * Added the ability to send multiple bids in one ad request for mediaforce bid adapter * Fixes after review for mediaforce bid adapter * Fix typo in mediaforce bid adapter Co-authored-by: ksanksana <little.grey.goblin@gmail.com>
* Prebid JS Native Phase 2 update: 1) Key Suppression for Native keys with sendTargetingKeys set to false at nativeParams.sendTargetingKeys or within asset i.e. nativeParams.image.sendTargetingKeys. Logic as follows: - If nativeParams.sendTargetingKeys set to false but asset has sendTargetingKeys set to true then add the KV - Else if nativeParams.sendTargetingKeys is set to true and asset does not have sendTargetingKeys defined or it is set to true then add KV - Else if nativeParams.sendTargetingKeys is not defined and asset does not have sendTargetingKeys defined or it is set to true then add KV If no conditions met then key is suppressed 2) Adds rendererUrl or adTemplate to the bid object for easy retrieval if assets requested from creative 3) Adds new logic to receiveMessage function in secureCreatives.js to answer data.action of 'allAssetRequest' with all available assets on the bid that have a value 4) Adds new native keys to constants.json * Update to simplify send asset logic * Fixed asset location typo * Update to include message listener for native resize and update adObject for auction to include creative height and trigger resize Co-authored-by: Michael Moschovas <mmoschovas@NY-Moschovas.local>
* align locator + fix remove listener * update comment Co-authored-by: Reinout Stevens <reinout@crazygames.com>
* EX-2549 Pass segments parameter as imp.ext.dealids array * EX-2549 Address Jon's feedback * EX-2549 Reworked the solution * EX-2549 Blackbird compatibility * EX-2549 Address Jon's comments * EX-2549 Addressed upstream PR comments * added floor module support * added function check * rerun test Co-authored-by: Egor Gordeev <egordeev@lineate.com> Co-authored-by: Egor Gordeev <48566506+egsgordeev@users.noreply.github.com>
* Add the root domain check method as a global method added for use modules * Add a date suffix to keep the test cookie random * Per review, moved the findRootDomain method to utils out of the userId modules * More the domain method back the user module but attach it to the submodule so that userId modules can have access to it * Remove the storageManager as it is no longer used in utils * Add the GVLID to the lotamePanoramaIdSystem * Use the GVL ID in the storage manager as well
* Migrating to Prebid 1.0 * Migrating to Prebid 1.0 * Fix spec * add gdpr and usp * remove changes in gdpr_hello_world.html * Update gdpr_hello_world.html add spaces * add user syncs * remove comments * tests * add fpd to request Co-authored-by: atkachov <atkachov91@admixer.ua>
* Add Adomain Targeting Key * add default targeting key Co-authored-by: Veronica Kim <vkim@vkim-mac.lan>
* PBS anti alias * lint * lint * update test * update test * Unit tests + dynamic aliasing * test bidder factory
* Add video support, refactor code * Add zoneId, refactor Co-authored-by: yegorheiz <yegorheiz@gmail.com>
* add AdTrue bid adapter * add AdTrue Bid Adapter unit tests * add AdTrue Bid Adapter unit tests * add AdTrue bid adapter * add AdTrue Bid Adapter unit tests * add AdTrue Bid Adapter unit tests * add AdTrue bid adapter * adtrue usersync udpate * adtrue usersync udpate * #adtrue bidder usersync udpate * #Refactoring code & add unit test * Update package.json * Update package-lock.json * 1. Merge branch 'master' of https://github.com/prebid/Prebid.js 2.AdTrue Bid Adapter Refactoring code * 1. Merge branch 'master' of https://github.com/prebid/Prebid.js 2.AdTrue Bid Adapter Refactoring code * removing a package-lock.json from PR * - removing a package-lock.json from PR - AdTrue bidder: refactoring code & add unit test * - removing a package-lock.json from PR - AdTrue bidder: refactoring code & add unit test * - removing a package-lock.json from PR - AdTrue bidder: refactoring code & add unit test * update package-lock.json from upstream
…6390) * Adding priceFloors Support to IX bid adapter and some refactoring * refactoring the getfloor logic, and removing dead code * newline at end of integration example * spacing issues lint fix * try catch around getFloor, in case the priceFloors module throws an exception * minor rename allU -> allu * falsey values fix, log prefix added
…ed by the tcf2 spec when gdprapplies is false (#6429) * Update index.js * Update prebidServerBidAdapter_spec.js * Update prebidServerBidAdapter_spec.js * Update prebidServerBidAdapter_spec.js
…before the {, causing the stored value not to be json parsed simply because of a space in the first character (#6467)
* Added bidglass adapter + test * PR Review Updates: - Added formal params to getUserSyncs function definition - getUserSyncs now always returns an array - Improved unit test coverage * PR Review Updates: - Removed unused methods: getUserSyncs, onTimeout, onBidWon, onSetTargeting - Removed getUserSyncs unit test - Removed "dead code" - Removed some unnecessary comments - Fixed usage of parseInt * Bid Glass Bid Adapter: pass options in bid request * Merge externally set targeting params * Updates to address gulp errors * Get `bidglass` reference from window
* Publish the Optimon platform's analytics adapter for prebid Added js and md files for the analytics adapter. * Fix wrong content in MD file * Fix wrong content in MD file * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter * Fixes ESlint styling * Removing DEF const * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter
* UID 2.0 User id submodule * UID 2.0 User id submodule * UID 2.0 User id submodule * UID 2.0 User id submodule * Resolving merge conflicts and review comments * Updating documentation * Renaming module * Fixing review comments * Fixing review comments * Fixing review comments * Fixing review comments * Fixing review comments * Updating source uid2.com to uidapi.com Co-authored-by: skocheri <skocheri@rubiconproject.com>
…ntegration support (#6436) * Change module H12 Media * Change module H12 Media * Change module H12 Media * Change module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media
* read and send getFloor value * improve robustness on OnEvent fields * add video mediatype to adyoulike adapter * improve robustness on OnEvent fields * handle instream cases * minor format fix * move the atob call to apply it on every Vast response * update adyoulike md file with video type * update adyoulike bidder doc * fix merge error on 'bid' var name * update adyoulike bidder doc
With the recent upgrade of npm we should be using the 'npm ci' option install packages. This provides a more reliable deployment that does not update packages on install. It will reduce check-ins of improper package-lock.json and provide greater assurance that a stable node_modules is deployed.
* fix confusing comment * refactor(openxBidAdapter): extract enrichQueryWithFloors * PBID-1194: add floor for Video
… on the bidObject (#6461)
…he user is in the control group of A/B testing (#6471)
* add connectionType to the bidRequest * remove a console.log * put connectionType in the payload * more secure connectionType access * add a unit test for connectionType * fix connectionType typo
* addefeend bid adapter implementation * fixed parameter documentation Co-authored-by: Mitschi <mitschi@addefend.com>
* adds meta field to bidresponse * adds meta mediatype and advertiserdomain default
* Update eids.js * Update eids_spec.js * Update eids.js * Update pubmaticBidAdapter_spec.js * Update eids.js * Update eids_spec.js * Update conversantBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Delete test/spec/adapters directory * Update userId_spec.js
* doceree adapter * add fix for impression register * fix linting issues * fix build issue * remove extra spaces * fixing - Implicit operand conversion * fixed ci/cd lint issue * update test case * support for advertiserdomains and updated test case * remove space to rerun test cases * remove the client side creative creation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information