Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(SvelteKit): fix Google Tag Manager example #570

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

a4vg
Copy link
Contributor

@a4vg a4vg commented Mar 18, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

The Google Tag Manager example for SvelteKit is wrong, when trying to use gtag it throws a gtag is not defined error. The reason it fails (not explicitly declaring the function as global) also applies to other scripts.

Use cases and why

  • Using Google Tag Manager correctly on SvelteKit.
  • Making global functions and variables available

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 6:18pm

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @a4vg

@gioboa gioboa merged commit 0258d26 into QwikDev:main Mar 18, 2024
8 checks passed
benmccann added a commit to benmccann/partytown that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants