fix: fix integration with vtex / spa #593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi thanks for your help,.can we add a few tests to cover this fix? |
gioboa
changed the title
|
@arturmagalhaesjr is there any chance you can add a test for this? |
gioboa
requested changes
Nov 16, 2024
There was a problem hiding this comment.
@arturmagalhaesjr thanks for opening this PR but without test I can't merge it, I'm so sorry.
I'm closing this for now, feel free to create a new PR with your improvements. 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
There is a bug in integrating VTEX and I suppose that happens in all SPA apps using partytown.
This code fixes that bug.
Use cases and why
Checklist: