fix: avoid syntax collision with self-invoking function #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
linting is failing on the file I didn't touch :-( |
|
I've just added a typescript version bump that should solve the issue with the lint job #616 |
|
unfortunately this fix breaks other usages, converted to draft anyway it would be nice to solve the issue anyhow |
|
Thanks for the update, let's create an issue for that and we can link this PR too. I'll close this one because I would like to have no pending PRs in the list. Thanks for your help btw 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Currently, the replacement of
thissymbol includes an expression wrapped with braces. It might cause an incorrect syntax if the previous function declaration has no semicolon at the endExample:
setupUid2Sdkis called immediatelyI suggest an adjustment to avoid syntax collision in 3rd party scripts since we have no control over those scripts. Instead of an expression in braces, we can encapsulate this logic using a function
Checklist: