Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ability to use partytown with scripts with relative paths #631

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented Oct 8, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Hi. Thanks for your cool project!

I am currently having a problem when using the script on sites with relative paths. The site I'm working on is published on different domains and has different paths.

For this reason I currently have to use a hack in my Rspack config:

partytownSnippet: partytownSnippet({
  lib: './',
}).replace('"/"', '"."'),

The current PR adds the ability to use it with relative paths.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:25pm

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @azat-io for your commitment
Can you update the docs as well https://partytown.builder.io/configuration ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants