fix(create-app): tmpdir handling (#5938)

QwikDev · Mar 4, 2024 · b85761c · b85761c
1 parent 1995753
commit b85761c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/create-qwik/src/run-create-interactive-cli.ts b/packages/create-qwik/src/run-create-interactive-cli.ts
@@ -111,7 +111,7 @@ export async function runCreateInteractiveCli(): Promise<CreateAppResult> {
 
   if (!runDepInstall) {
     backgroundInstall.abort();
-  } else {
+  } else if (typeof backgroundInstall.success === 'undefined') {
     try {
       const joke = await confirm({
         message: `Finishing the install. Wanna hear a joke?`,

diff --git a/packages/qwik/src/cli/utils/install-deps.ts b/packages/qwik/src/cli/utils/install-deps.ts
@@ -23,10 +23,6 @@ export function backgroundInstallDeps(pkgManager: string, baseApp: IntegrationDa
 
   const { install, abort } = installDeps(pkgManager, tmpInstallDir);
 
-  install.finally(() => {
-    fs.rmdirSync(tmpInstallDir, { recursive: true });
-  });
-
   const complete = async (outDir: string) => {
     let success = false;
 
@@ -63,6 +59,7 @@ export function backgroundInstallDeps(pkgManager: string, baseApp: IntegrationDa
         }
 
         success = true;
+        fs.rmdirSync(tmpInstallDir, { recursive: true });
       }
     } catch (e: any) {
       if (e) {
@@ -86,7 +83,14 @@ export function backgroundInstallDeps(pkgManager: string, baseApp: IntegrationDa
     return success;
   };
 
-  return { abort, complete };
+  const out = {
+    abort: () => abort().finally(() => fs.rmdirSync(tmpInstallDir, { recursive: true })),
+    complete,
+    success: undefined as boolean | undefined,
+  };
+  install.then((success) => (out.success = success));
+
+  return out;
 }
 
 function setupTmpInstall(baseApp: IntegrationData) {