-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐞] Invalid module "@qwik-city-plan" is not a valid package name imported from #6024
Comments
Can you try downgrading vite to 4.0, and if that fixes it, try to find which version breaks it |
@wmertens Thanks for quick response. Sure, lemme try |
@wmertens downgrading Vite to 4.x, 4.0 and 3.x versions didn't help, unfortunately. I'll play around with other packages |
Ok then it's probably a bug in the Qwik City plugin |
Is there a fix yet? I'm having the same problem. |
you have to move your deps to devDeps |
@wmertens this is a problem because of how we setup the vite.config https://github.com/frixaco/repro-qwik-city-plan-error/blob/7a9c27ecdaf3ae2fde5da84d4723618fe06665db/vite.config.ts#L34 and it's not clear. by default packages are installed in deps rather than devDeps so it's confusing because the error also doesn't provide any info |
Thank you @PatrickJS! Moving |
Yes good point. Perhaps we should just comment that code and explain that for optimal packaging you need to use that |
Checking the deps is possible too but kinda hard. For sure anything that depends on qwik should be bundled and we could do that automatically |
Actually I think that already happens and we're overriding it |
if we have a better error that should be good enough |
this is fixed in latest starter by asking the dev to move anything qwik into devDeps |
Which component is affected?
Qwik Runtime
Describe the bug
Same/Related: #3641
Full error:
TypeError [ERR_INVALID_MODULE_SPECIFIER]: Invalid module "@qwik-city-plan" is not a valid package name imported from /Users/frixaco/dev/my/test-qwik-city-plan/node_modules/.pnpm/@builder.io+qwik-city@1.5.1_@types+node@20.11.28/node_modules/@builder.io/qwik-city/index.qwik.mjs
Let me know if you need more info.
Reproduction
https://github.com/frixaco/repro-qwik-city-plan-error
Steps to reproduce
(Same as the mentioned issue above)
pnpm create qwik
pnpm add @modular-forms/qwik
routes/index.tsx
:pnpm preview
System Info
Additional Information
No response
The text was updated successfully, but these errors were encountered: