-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(auth): correct @auth/qwik documentation and add migration guide #6730
Conversation
|
@gioboa , should I also add an alert or warning that notifies users that are upgrading that the routes changed? I think this change might be easy to miss. |
👍 that's a great idea. You can add a note for the users that are upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cwoolum
@gioboa , I added some guidance as well as a couple diffs to help others easily migrate 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks it looks great to me
…n guide (QwikDev#6730)" This reverts commit 14b27c8.
…migration guide (QwikDev#6730)"" This reverts commit f30a2be.
…n guide (QwikDev#6730)" This reverts commit 14b27c8.
…n guide (QwikDev#6730)" This reverts commit 14b27c8.
…n guide (QwikDev#6730)" This reverts commit 14b27c8.
fixes #6729
Overview
What is it?
Description
The new
@auth/qwik
package has different routes than the original@builder.io/qwik-auth
package. In the new package, the routes are no longer prefixed with/api
. This can lead to confusion when the user tries to gate pages and gets redirected to a 404.Use cases and why
@auth/qwik
package.Checklist: