Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync$): serialize "minified" function #6944

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(sync$): serialize "minified" function #6944

merged 1 commit into from
Oct 7, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Oct 7, 2024

It's not super minified, but it's better than before.

For example, qwik.dev had this in the sync funcs script tag:

() => {
    ((window1, history1) => {
      var _a3;
      if (!window1._qcs && history1.scrollRestoration === "manual") {
        window1._qcs = true;
        const scrollState = (_a3 = history1.state) == null ? void 0 : _a3._qCityScroll;
        if (scrollState) window1.scrollTo(scrollState.x, scrollState.y);
        document.dispatchEvent(new Event("qcinit"));
      }
    })(window, history)})

which was copied verbatim with spacing.
Now it will be without spaces.

@wmertens wmertens requested a review from a team as a code owner October 7, 2024 21:37
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 24cf2d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens wmertens enabled auto-merge (squash) October 7, 2024 21:38
@wmertens wmertens merged commit 9d4a661 into main Oct 7, 2024
19 checks passed
@wmertens wmertens deleted the fix-sync-mini branch October 7, 2024 21:53
Copy link

pkg-pr-new bot commented Oct 7, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6944
npm i https://pkg.pr.new/@builder.io/qwik-city@6944
npm i https://pkg.pr.new/eslint-plugin-qwik@6944
npm i https://pkg.pr.new/create-qwik@6944

commit: 24cf2d9

@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants