Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetchpriority option for link + Fix prefetch url in dev mode #6947

Merged
merged 8 commits into from
Oct 14, 2024

Conversation

GrandSchtroumpf
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

prefetch strategy linkInsert always has fetchpriority set to "auto" which might result into busying the browser at load time. With linkFetchPriority we can set the bundle prefetch to "low" to give an indication to the browser.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality -> no existing test infra for this par for the code

@GrandSchtroumpf GrandSchtroumpf requested review from a team as code owners October 8, 2024 13:16
Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: be9d7a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wmertens
wmertens previously approved these changes Oct 13, 2024
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge October 13, 2024 21:36
auto-merge was automatically disabled October 14, 2024 09:47

Head branch was pushed to by a user without write access

wmertens
wmertens previously approved these changes Oct 14, 2024
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wmertens
wmertens previously approved these changes Oct 14, 2024
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.changeset/unlucky-experts-check.md Outdated Show resolved Hide resolved
@wmertens wmertens enabled auto-merge (squash) October 14, 2024 15:13
@wmertens wmertens merged commit 4dfcba5 into QwikDev:main Oct 14, 2024
18 checks passed
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants