Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release version bump #240

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Post release version bump #240

merged 3 commits into from
Sep 13, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Sep 13, 2024

Did I forget anything?

@mcol mcol added this to the Release version 1.0.0 milestone Sep 13, 2024
Copy link
Member

@RLumSK RLumSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marco, looks good. And thanks for fixing the DOI link; very stupid mistake I made there.

@RLumSK
Copy link
Member

RLumSK commented Sep 13, 2024

@mcol Can you please check for the signature. I had on purpose protected the branch and I don't want to bypass it. After I can merge.

@mcol
Copy link
Contributor Author

mcol commented Sep 13, 2024

I've just set it up, but the commits in this PR are unsigned. Should I re-push with signed commits?

@RLumSK RLumSK merged commit ee736cb into master Sep 13, 2024
10 checks passed
@mcol mcol deleted the post-release-version-bump branch September 13, 2024 10:28
@mcol mcol mentioned this pull request Nov 14, 2024
@mcol mcol modified the milestones: Release version 1.0.0, v0.9.26 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants