Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the bbmle::profile() try_harder option in calc_MinDose() #241

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Don't use the bbmle::profile() try_harder option in calc_MinDose() #241

merged 2 commits into from
Sep 13, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Sep 13, 2024

This makes it fail much faster when a converging fit for the profile log-likelihood cannot be found. Fixes #234.

@mcol
Don't use the bbmle::profile() try_harder option in calc_MinDose().
0a4e193 
This makes it fail much faster when a converging fit for the profile
log-likelihood cannot be found.
RLumSK
RLumSK approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@RLumSK RLumSK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, although I had thought that the try_harder = TRUE makes it
fail faster. But OK for me, you can do merge yourself.

@mcol
Copy link
Contributor Author

mcol commented Sep 13, 2024

No, try_harder = TRUE makes it do more work in attempting to find a fit, so it's going to take longer before it gives up.

@mcol mcol merged commit 6ff6a6f into master Sep 13, 2024
10 checks passed
@mcol mcol deleted the issue_234 branch September 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RLumSK RLumSK RLumSK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calc_MinDose() can get unbearably slow if bbmle() doesn't find a fit
2 participants
@mcol @RLumSK