Add the expect_snapshot_RLum() test helper and start using it #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some snapshot tests for
analyse_SAR.TL(), as I'm working on some changes to that function, and luckily there are just a few tests.I've written the
expect_snapshot_RLum()helper as we have to ignore the.uidand.pidfields, which would never match. The expected output is saved in thetests/testthat/_snaps/analyse_SAR.TL.mdand contains a JSON representation of the outputRLum.Resultsobject.We need to see how CI reacts to that, there may be tolerances that need to be set to satisfy different machine configurations. 🤞
This is the start of #243.