Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more abbreviations for regions #13

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Use more abbreviations for regions #13

merged 1 commit into from
Nov 21, 2022

Conversation

pg9182
Copy link
Member

@pg9182 pg9182 commented Nov 20, 2022

Makes it shorter and align more closely with each other and common convention.

@pg9182
pkg/regionmap: Use more abbreviations
ba693d1 
Makes it shorter and align more closely with each other and common
convention.
@pg9182 pg9182 changed the title pkg/regionmap: Use more abbreviations Use more abbreviations for regions Nov 20, 2022
@pg9182
Copy link
Member Author

pg9182 commented Nov 20, 2022

RFC @ASpoonPlaysGames @GeckoEidechse.

ASpoonPlaysGames
ASpoonPlaysGames approved these changes Nov 20, 2022
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I personally would prefer to also abbreviate North/South/East/West, but this is fine

GeckoEidechse
GeckoEidechse approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. If you wanna be sure it's understood by most players just ask #general what EU, CA, etc stands for :P

@GeckoEidechse GeckoEidechse mentioned this pull request Nov 20, 2022
Merged
12 tasks
@pg9182 pg9182 merged commit b3d1c42 into R2Northstar:main Nov 21, 2022
@pg9182 pg9182 deleted the regionmap branch November 21, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@emma-miler emma-miler emma-miler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pg9182 @emma-miler @GeckoEidechse @ASpoonPlaysGames