-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove placeholder_playerdata #459
Conversation
Not needed since v1.10 (R2Northstar/NorthstarLauncher@841881a).
Requesting review from @BobTheBob9 cause he wrote R2Northstar/NorthstarLauncher#171 |
I've already talked to @BobTheBob9 about this while we were discussing Atlas default pdata updates and the big refactor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self that this file is the only file in R2Northstar
folder, so removing it will remove the folder from GitHub repo. Need to check CI code so that it isn't setup to expect that folder existing and as such break when the folder is gone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine since the next command uses mkdir -p
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh actually, how does reset persistence work without it? ^^"
> Shouldn't break anything he said in vc |
Well, the idea was that the docker update for the NS version would include the required changes. Unfortunately, unlike v1.13.0, I wasn't available at the time of release... |
Not needed since v1.10 (R2Northstar/NorthstarLauncher@841881a).