Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove placeholder_playerdata #459

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Conversation

pg9182
Copy link
Member

@pg9182 pg9182 commented Apr 22, 2023

Not needed since v1.10 (R2Northstar/NorthstarLauncher@841881a).

@pg9182
Copy link
Member Author

pg9182 commented Apr 22, 2023

@GeckoEidechse

@GeckoEidechse
Copy link
Member

GeckoEidechse commented Apr 22, 2023

Requesting review from @BobTheBob9 cause he wrote R2Northstar/NorthstarLauncher#171

@pg9182
Copy link
Member Author

pg9182 commented Apr 22, 2023

I've already talked to @BobTheBob9 about this while we were discussing Atlas default pdata updates and the big refactor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self that this file is the only file in R2Northstar folder, so removing it will remove the folder from GitHub repo. Need to check CI code so that it isn't setup to expect that folder existing and as such break when the folder is gone.

Copy link
Member Author

@pg9182 pg9182 Apr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine since the next command uses mkdir -p.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh actually, how does reset persistence work without it? ^^"

@GeckoEidechse GeckoEidechse merged commit 39ac00c into R2Northstar:main Apr 29, 2023
@GeckoEidechse
Copy link
Member

> Shouldn't break anything he said in vc
> breaks docker image in two separate ways :,)

@pg9182
Copy link
Member Author

pg9182 commented Apr 29, 2023

Well, the idea was that the docker update for the NS version would include the required changes. Unfortunately, unlike v1.13.0, I wasn't available at the time of release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants