Refactor for v3 #10
Refactor for v3 #10
Conversation
uh wdym? This repo is only be DiscordRPC stuff. I would just release that as a separate plugin. Could maybe add it to tools org if you wanna ig? |
just asking if it should be included with n* |
Given that we don't have many plugins in general yet (outside of yours :P) I don't really see the need to. Trying to maintain too much backwards compatibility introduces a lot of baggage especially longterm. So as long as there isn't a specific need for it, I wouldn't include it with Northstar ^^ |
|
Just a note for anyone merging this; rrplug for v3 hasn't been published to crates io yet since I can't quite decide on some major things. Also rrplug should pinned to a specific commit hash or to version in the future. |
There was a problem hiding this comment.
Confirmed working in testing together with R2Northstar/NorthstarLauncher#472 and R2Northstar/NorthstarMods#652
Joined a bunch of servers and watched Discord activity status update
(Still wanna do some code review though)
| @@ -6,9 +6,10 @@ edition = "2021" | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| rrplug = { version = "2.0.0", features = ["presence"] } | |||
| rrplug = { git = "https://github.com/R2NorthstarTools/rrplug" } | |||
There was a problem hiding this comment.
What's the current state of publishing to crates.io?
I'm fine with merging while still pointing to git repo but I'd kinda wanna see rrplug for v3 being on crates.io soon after so that it's more accessible to anyone developing plugins ^^
There was a problem hiding this comment.
I can publish it at any moment since it's basically done, but I would rather not.
The main is issue is that I don't quite know how much traits/generics I need over macros.
currently it's mix of both. I want to remove as much macros as possible. Due to how rrplug has to interact with the plugin system and the engine for some cases it's hard to decide what would be better.
refactor for v3 with fixes :)
also should this repo contain a plugin to load v2 plugins on v3 or should it be a separate thing?