-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Interface for Game Invites #22
Conversation
I haven't been able to try out that PR yet, how do the invites actually work? For the Discord side, I guess it uses https://support.discord.com/hc/en-us/articles/115001557452-Game-Invites and from the Northstar side it just tells the client to just join a specific server id? |
The pr only handles discord invites and everything else is delegated to another plugin which is why there is an interface for it. It doesn't have to be the compartya plugin btw. |
should work |
I spliced out the |
ok, I will be waiting |
no waiting, testing 👉👈 |
well I still need to wait to test it XD |
How do I test this? I replaced my dll with this PR but Discord is not showing invites, also is there any squirrel hooks for this? Because if this gets in, i might update my Matchmaking Mixtape Menu to make use of this feature and restore the "Invite Friends" button in the main lobby. |
The pr just adds interfaces to this plugin so other plugins could handle invites. In the description I did mention a plugin that uses the interface :> |
Tested, works. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working in testing.
First of all game didn't crash and DiscordRPC still worked.
Tested compartya together with @catornot with this PR.
After some initial bugs with compartya (couldn't resolve local IP due to simplistic ipconfig
parsing) we got it working and @catornot joined my party and got pulled into servers I joined and similarly I got pulled into servers when I joined @catornot's party.
(still not a fan of updating |
apparently game invites still work but only the invites so the lobbies infrastructure isn't maintained by discord.
So discord rpc now exposes a interface for it :)
I have made a plugin that uses the interface already : https://github.com/catornot/compartya
how to test