Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interface for Game Invites #22

Merged
merged 16 commits into from
Sep 7, 2024

Conversation

catornot
Copy link
Member

@catornot catornot commented Feb 5, 2024

apparently game invites still work but only the invites so the lobbies infrastructure isn't maintained by discord.

So discord rpc now exposes a interface for it :)

I have made a plugin that uses the interface already : https://github.com/catornot/compartya

how to test

@GeckoEidechse
Copy link
Member

I haven't been able to try out that PR yet, how do the invites actually work?

For the Discord side, I guess it uses https://support.discord.com/hc/en-us/articles/115001557452-Game-Invites and from the Northstar side it just tells the client to just join a specific server id?

@catornot
Copy link
Member Author

catornot commented Feb 8, 2024

For the Discord side, I guess it uses https://support.discord.com/hc/en-us/articles/115001557452-Game-Invites and from the Northstar side it just tells the client to just join a specific server id?

The pr only handles discord invites and everything else is delegated to another plugin which is why there is an interface for it. It doesn't have to be the compartya plugin btw.

@catornot
Copy link
Member Author

catornot commented Jul 5, 2024

should work
rustc approved 👍

@GeckoEidechse
Copy link
Member

I spliced out the rrplug 4.0.0 related changes into #24 so that we can get them merged and released faster as part of the next patch release.

@catornot
Copy link
Member Author

catornot commented Jul 6, 2024

ok, I will be waiting

@GeckoEidechse
Copy link
Member

ok, I will be waiting

no waiting, testing 👉👈

@catornot
Copy link
Member Author

catornot commented Jul 8, 2024

ok, I will be waiting

no waiting, testing 👉👈

well I still need to wait to test it XD

@Zanieon
Copy link
Contributor

Zanieon commented Jul 9, 2024

How do I test this? I replaced my dll with this PR but Discord is not showing invites, also is there any squirrel hooks for this? Because if this gets in, i might update my Matchmaking Mixtape Menu to make use of this feature and restore the "Invite Friends" button in the main lobby.

@catornot
Copy link
Member Author

How do I test this? I replaced my dll with this PR but Discord is not showing invites, also is there any squirrel hooks for this? Because if this gets in, i might update my Matchmaking Mixtape Menu to make use of this feature and restore the "Invite Friends" button in the main lobby.

The pr just adds interfaces to this plugin so other plugins could handle invites.

In the description I did mention a plugin that uses the interface :>

@catornot
Copy link
Member Author

catornot commented Sep 6, 2024

can this pr just be merged?
image

@EM4Volts
Copy link

EM4Volts commented Sep 6, 2024

Tested, works. thanks.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

First of all game didn't crash and DiscordRPC still worked.

Tested compartya together with @catornot with this PR.

After some initial bugs with compartya (couldn't resolve local IP due to simplistic ipconfig parsing) we got it working and @catornot joined my party and got pulled into servers I joined and similarly I got pulled into servers when I joined @catornot's party.

@GeckoEidechse
Copy link
Member

(still not a fan of updating Cargo.lock in the same PR but oh well)

@GeckoEidechse GeckoEidechse changed the title Add Game Invites Add Interface for Game Invites Sep 7, 2024
@GeckoEidechse GeckoEidechse merged commit b11a92d into R2Northstar:main Sep 7, 2024
2 checks passed
@catornot catornot deleted the game-invites branch October 10, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants