Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow mods to load biks that aren't already present in r2/media #137

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

BobTheBob9
Copy link
Member

atm, modded videos will only be loaded if they are overriding a video that's present in r2/media already, nopping out a check in the engine video loading function forces the game to attempt to load it regardless of whether it's there, so it'll attempt to load modded biks

in testing that hasn't caused any issues with either vanilla, overriden or custom biks

Copy link
Member

@EladNLG EladNLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ¯_(ツ)_/¯

Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten PR 💀

@Dundurhedd
Copy link

This should be like, merged, n stuff, it would be really epic n things. i would luv u forever. thank you for taking the time to read my comment. :))))

@BobTheBob9
Copy link
Member Author

I fr did just forget this

@BobTheBob9 BobTheBob9 merged commit e518c02 into main Aug 20, 2022
@BobTheBob9 BobTheBob9 deleted the fix-mod-only-biks-pr branch August 20, 2022 18:19
GeckoEidechse added a commit that referenced this pull request Aug 25, 2022
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
GeckoEidechse added a commit that referenced this pull request Sep 12, 2022
GeckoEidechse added a commit that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants