Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some members of MasterServerManager #266

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

GeckoEidechse
Copy link
Member

Part of refactor. I basically took the changes from 037113d and added them onto main, excluding the debug build fix as that was related to a commit on refactor that is not yet present on main.

This is basically 9ab7c43 from refactor but without the debug build crash fix as that was introduced in a commit in refactor not present on main
Copy link
Member Author

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no issues in testing.

@GeckoEidechse GeckoEidechse mentioned this pull request Sep 6, 2022
@BobTheBob9 BobTheBob9 merged commit 4d64528 into main Sep 7, 2022
@BobTheBob9 BobTheBob9 deleted the refactor-rename-masterservermanager-fields branch September 7, 2022 22:16
GeckoEidechse added a commit that referenced this pull request Sep 14, 2022
This is basically 9ab7c43 from refactor but without the debug build crash fix as that was introduced in a commit in refactor not present on main

Co-authored-by: BobTheBob <32057864+BobTheBob9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants