Move include directory #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the `include` directory from the NorthstarDLL project folder to the solution folder. This allows both the DLL and Launcher project to target it properly.
Closed
|
How to test: try to compile the solution with this PR. If it succeeds, it means its working |
pg9182
requested changes
Nov 18, 2022
pg9182
approved these changes
Nov 22, 2022
GeckoEidechse
added
the
needs testing
GeckoEidechse
approved these changes
Nov 27, 2022
|
I assume I can merge this now, @pg9182? |
GeckoEidechse
removed
the
needs testing
|
Looks okay to me, but I haven't run it. |
|
looks fine to me, will build and run in a bit to make sure |
|
(2 people reviewed code but never put it down as review so I didn't notice :c) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested on discord, this these commits were taken from the Splash PR and moved into a new one.
The main reason for the move is so that
NorthstarLauncheralso has access torapidjsonas it's needed for parsing JSON defining custom splash screen.