Fix script compile errors not being flushed to log file #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeckoEidechse
changed the title
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
|
uwu |
emma-miler
approved these changes
Nov 24, 2022
|
@pg9182 wanna test this with Docker? |
GeckoEidechse
added
needs testing
emma-miler
approved these changes
Nov 27, 2022
GeckoEidechse
removed
the
needs code review
GeckoEidechse
approved these changes
Nov 27, 2022
There was a problem hiding this comment.
Confirmed working in testing by inserting syntax error into some Squirrel scripts on purpose
Before:
...
[21:36:40] [FILESYSTM] [info] Changing mod search path from C:\Program Files (x86)\Steam\steamapps\common\Titanfall2\R2Northstar\mods\Northstar.CustomServers\mod to R2Northstar/mods\Northstar.Custom
[21:36:40] [FILESYSTM] [info] Changing mod search path from C:\Program Files (x86)\Steam\steamapps\common\Titanfall2\R2Northstar\mods\Northstar.Custom\mod to R2Northstar/mods\Northstar.CustomServers
[21:36:40] [FILESYSTM] [info] Changing mod search path from C:\Program Files (x86)\Steam\steamap
After:
...
[22:47:38] [FILESYSTM] [info] Changing mod search path from C:\Program Files (x86)\Steam\steamapps\common\Titanfall2\R2Northstar\mods\Northstar.Custom\mod to R2Northstar/mods\Northstar.CustomServers
[22:47:38] [SCRIPT SV] [error] COMPILE ERROR expected ")", found identifier "asdasd"
[22:47:38] [SCRIPT SV] [error] lobby/_lobby.gnut line [22] column [33]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i can't spell before :(