Add platform information to User-Agent #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg9182
force-pushed
the
ua-platform
branch
2 times, most recently
from
0bc0372
to
0edb3a9
Compare
p0358
reviewed
Dec 11, 2022
pg9182
force-pushed
the
ua-platform
branch
2 times, most recently
from
326c953
to
0ec0c45
Compare
pg9182
commented
Dec 11, 2022
There was a problem hiding this comment.
Tested on the dedicated server (ghcr.io/pg9182/northstar-dedicated-ci:1-tf2.0.11.0-ns1.10.9-ci.59de24a5.51.3671191399-nslauncher.10dc1b0a.3671162384-nsmods.4a1ff7d1).
Example: R2Northstar/0.0.0+dev (Dedicated) Windows/10.0.17763 Wine/7.0 (wine-7.0) Linux/5.19.6-200.fc36.x86_64
GeckoEidechse
approved these changes
Dec 11, 2022
|
(@pg9182 assured me he tested on client on Linux as well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #361