New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pedantic fix for #391 (use if-else instead of if) #392

Merged

BobTheBob9 merged 1 commit into R2Northstar:main from p0358:fix_391_pedantic

Jan 20, 2023

Contributor

p0358 commented Jan 6, 2023

So that me and @GeckoEidechse can calmly sleep knowing it was fixed xD

These ifs are mutually exclusive hence the fix (we check for byte 1).


          Pedantic fix for previous commit (3cfd6f9) (use if-else instead of if)

e3e477e

ASpoonPlaysGames approved these changes

View reviewed changes

Contributor

ASpoonPlaysGames left a comment

I mean not much to review here, but yeah

BobTheBob9 approved these changes

View reviewed changes

BobTheBob9 merged commit 3a61626 into R2Northstar:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet