Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back sq_getobject and sq_getthisentity for the client and ui vm #428

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Bring back sq_getobject and sq_getthisentity for the client and ui vm #428

merged 1 commit into from
Mar 30, 2023

Conversation

catornot
Copy link
Member

@catornot catornot commented Mar 3, 2023 •
edited
Loading

for some reason they were removed in pr #310.
I need sq_getobject for some plugins on the ui vm and since they are null, I can't use them.

would close #427 :)

uniboi
uniboi approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@uniboi uniboi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the functions have been removed for client on accident

GeckoEidechse
GeckoEidechse approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok no clue why they were removed in the original PR.

(didn't test PR btw)

@GeckoEidechse GeckoEidechse merged commit 35696d3 into R2Northstar:main Mar 30, 2023
@catornot catornot deleted the bring_funs_back branch April 21, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniboi uniboi uniboi approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

__sq_getobject and __sq_getthisentity are null on client and ui
3 participants
@catornot @GeckoEidechse @uniboi