Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic mods blacklisting #474

Merged
merged 8 commits into from
Jul 2, 2023
Merged

Basic mods blacklisting #474

merged 8 commits into from
Jul 2, 2023

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Jun 21, 2023 •
edited by GeckoEidechse
Loading

Allows blacklisting mods by mod name. This is done in regards to the upcoming Mod Settings release as too many mods have not been updated yet to not include Mod Settings.

@F1F7Y F1F7Y requested a review from GeckoEidechse June 22, 2023 10:17
@F1F7Y F1F7Y added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jun 29, 2023
@pg9182 pg9182 self-requested a review June 30, 2023 01:17
pg9182
pg9182 reviewed Jul 2, 2023
View reviewed changes
NorthstarDLL/mods/modmanager.cpp Outdated Show resolved Hide resolved
NorthstarDLL/mods/modmanager.h Outdated Show resolved Hide resolved
GeckoEidechse
GeckoEidechse approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

@GeckoEidechse GeckoEidechse removed the needs testing Changes from the PR still need to be tested label Jul 2, 2023
GeckoEidechse
GeckoEidechse approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works in testing.

@F1F7Y
Copy link
Member Author

F1F7Y commented Jul 2, 2023

Still works in testing.

Me when i test my things before pushing

@GeckoEidechse
Copy link
Member

Still works in testing.

Me when i test my things before pushing

Surprisingly few people do :dread:

GeckoEidechse
GeckoEidechse approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works in testing

@GeckoEidechse GeckoEidechse merged commit 10cb6e5 into R2Northstar:main Jul 2, 2023
@F1F7Y F1F7Y deleted the bandage-solution branch July 26, 2023 13:13
@GeckoEidechse GeckoEidechse removed the needs code review Changes from PR still need to be reviewed in code label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pg9182 pg9182 pg9182 left review comments

@uniboi uniboi uniboi left review comments

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@F1F7Y @GeckoEidechse @uniboi @pg9182 @Alystrasz