Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RelWithDebInfo configuration #483

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Jun 25, 2023

Some contributors are having trouble with the game freezing when running Debug binaries. RelWithDebInfo fixes this for some.

@F1F7Y
Copy link
Member Author

F1F7Y commented Jun 25, 2023

Github actions use Release which wasnt changed at all ( neither was Debug ). So there should be no change in artifacts

@pg9182
Copy link
Member

pg9182 commented Jun 29, 2023

Honestly, we should consider just making RelWithDebInfo the default and only supported target.

Copy link
Member

@pg9182 pg9182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, builds correctly.

@pg9182 pg9182 merged commit 2bd882e into R2Northstar:main Jun 29, 2023
@F1F7Y F1F7Y deleted the relwithdebinfo branch July 26, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants