Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mileslog_enable convar #515

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Add mileslog_enable convar #515

merged 4 commits into from
Oct 10, 2023

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Jul 26, 2023

Adds a convar to toggle whether we should log from the miles log func

Most of these warnings are warnings about events being starved, in some cases slowing down the game due to the number of log calls.

Closes #509

@F1F7Y F1F7Y added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jul 27, 2023
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Audio starved logging is not present with mileslog_enable set to 0

@ASpoonPlaysGames ASpoonPlaysGames added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jul 30, 2023
@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Sep 2, 2023
@GeckoEidechse GeckoEidechse mentioned this pull request Oct 3, 2023
Merged
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Oct 3, 2023 •
edited
Loading

Uh did anyone test this? PR review only mentions code review ^^

I'm blind.

@ASpoonPlaysGames
Copy link
Contributor

Uh did anyone test this? PR review only mentions code review ^^

No it doesn't

@GeckoEidechse
Copy link
Member

Merging based on reviews.

@GeckoEidechse GeckoEidechse changed the title Add mileslog_enable Add mileslog_enable convar Oct 10, 2023
@GeckoEidechse GeckoEidechse merged commit c1745b2 into R2Northstar:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MilesLog spams logs freezing up the game
4 participants
@F1F7Y @GeckoEidechse @ASpoonPlaysGames @Alystrasz