Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add a safeguard to map command" #561

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Revert "Add a safeguard to map command" #561

merged 1 commit into from
Oct 3, 2023

Conversation

GeckoEidechse
Copy link
Member

#529 breaks Docker image as per pg9182/northstar-dedicated#70

As such we should revert the change until we can figure out the reason for breakage.

@GeckoEidechse GeckoEidechse added the bug Something isn't working label Oct 3, 2023
Jan200101
Jan200101 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm, does revert.

@GeckoEidechse GeckoEidechse merged commit 2a3be90 into main Oct 3, 2023
4 checks passed
@GeckoEidechse GeckoEidechse deleted the revert-map-pr branch October 3, 2023 17:32
This was referenced Oct 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jan200101 Jan200101 Jan200101 approved these changes

@catornot catornot Awaiting requested review from catornot

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeckoEidechse @Jan200101