-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write date to logs #565
Write date to logs #565
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Replaced my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, date format uses the long variant 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, testing shows date now appears in log files.
This only affects the log files (and not things like the in-game console) right? |
This only shows in logs. |
One trade-off is that this change will increase log size due to preventing more characters for each line. Personally I think this trade-off is worth it. If there's no opposition to this PR I'll merge it within the next few hours or so. |
Would it be worth restricting this to only dedicated servers? Listen servers and clients shouldn't really be having the game open for multiple days at a time |
Users can sometimes send their logs as a That's basically the only idea I have in why we'd have it for clients and listen servers. We also recently reduced the spam of some lines in a couple of PRs so I don't personally see any issues with adding a little bit extra onto each line. |
as an alternative if this isn't "enough" reason, I can have spectre check imo it makes less sense to do it this way (spectre way), and instead just keep date in client logs, but it's an alternative |
Fair enough, good enough for me |
Imma count that whole discussion as primarily in favour of having date in logs on both server and client and merge as is ^^ |
Suggestion from #560
This PR adds dates to logs in the same format which the file name uses.
Closes #560