Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mixed indentation in utils.cmake #570

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Oct 11, 2023

The file had mixed indentation (spaces and tabs) when really it should've been spaces only from the beginning

I noticed the indentation change in #569 and spliced it out to make the diff of #569 proper on merge.

No testing needed as this only performs a whitespace change in utils.cmake. Check the diff with whitespace changes hidden to verify for yourself :P

The file had mixed indentation (spaces and tabs) when really it
should've been spaces only from the beginning
@GeckoEidechse GeckoEidechse added needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Oct 11, 2023
Copy link
Contributor

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just indention change 👍
Looks gucci

@GeckoEidechse GeckoEidechse merged commit a9a1e08 into main Oct 11, 2023
4 checks passed
@GeckoEidechse GeckoEidechse deleted the cmake-indent-with-spaces branch October 11, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs code review Changes from PR still need to be reviewed in code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants