Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make link to BUILD.md relative to README.md #571

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Make link to BUILD.md relative to README.md #571

merged 1 commit into from
Oct 11, 2023

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Oct 11, 2023 •
edited
Loading

Make link to BUILD.md relative to README.md instead of a hardcoded link to relevant GitHub page

No testing needed as it only modifies README.md.

@GeckoEidechse
Make link to BUILD.md relative to README.md
2c4cc3c 
instead of a hardcoded link to relevant GitHub page
@GeckoEidechse GeckoEidechse added needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Oct 11, 2023
itscynxx

This comment was marked as off-topic.

Sign in to view

RoyalBlue1
RoyalBlue1 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@RoyalBlue1 RoyalBlue1 left a comment •
edited by GeckoEidechse
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only changes a single line. Not much to review here. Just signing off.

@GeckoEidechse GeckoEidechse merged commit 16f8542 into main Oct 11, 2023
4 checks passed
@GeckoEidechse GeckoEidechse deleted the relative-link-readme branch October 11, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itscynxx itscynxx itscynxx approved these changes

@RoyalBlue1 RoyalBlue1 RoyalBlue1 approved these changes

Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs code review Changes from PR still need to be reviewed in code
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeckoEidechse @RoyalBlue1 @itscynxx