Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin communication handler init out of plugin manager init #581

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

Plugin state requires this to be initialised even if -noplugins is passed, but if -noplugins is passed, it doesn't get initialised.

Moving this to dllmain guarantees that it is initialised properly and prevents #580

closes #580

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 15, 2023
Copy link
Contributor

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works without a hitch.

Code is clean and moves the global init into the InitNS function, like many other things are.

@Jan200101 Jan200101 added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 15, 2023
@GeckoEidechse
Copy link
Member

Merging based on reviews.

@GeckoEidechse GeckoEidechse merged commit 98af0dc into R2Northstar:main Oct 15, 2023
2 checks passed
@GeckoEidechse GeckoEidechse mentioned this pull request Oct 15, 2023
@ASpoonPlaysGames ASpoonPlaysGames deleted the noplugins-fix branch January 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

-noplugins crashes the game on startup
3 participants