Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a better AccessModifierOffset in clang-format #619

Merged

Conversation

ASpoonPlaysGames
Copy link
Contributor

Default appears to be -2, which causes clang-format to mix tabs and spaces

@ASpoonPlaysGames ASpoonPlaysGames added the needs code review Changes from PR still need to be reviewed in code label Dec 18, 2023
@GeckoEidechse GeckoEidechse added the feedback wanted Feedback is wanted whether the changes by this PR are desired label Dec 19, 2023
@uniboi
Copy link
Contributor

uniboi commented Dec 19, 2023

what code is there to review

@ASpoonPlaysGames
Copy link
Contributor Author

what code is there to review

More just the formatting changes that this incurs

@GeckoEidechse
Copy link
Member

GeckoEidechse commented Dec 20, 2023

@uniboi precisely what @ASpoonPlaysGames said. There's obviously no code review but rather the question whether the changes are wanted or not. The needs code review label is just the closest we have to indicate that there's still a need for someone to look at the changes and decide whether they are wanted (next to the obvious feedback wanted label)

 

@ASpoonPlaysGames should we merge this before or after some primedev cherry-picks? primedev doesn't have it so it might increase the div unless someone backports it to there ^^

@ASpoonPlaysGames
Copy link
Contributor Author

@ASpoonPlaysGames should we merge this before or after some primedev cherry-picks? primedev doesn't have it so it might increase the div unless someone backports it to there ^^

idk, I fix formatting on primedev cherry picks anyway so i dont think it matters if this comes first for what i'm doing

@GeckoEidechse GeckoEidechse changed the title Set a better AccessModifierOffset in clang-format Set a better AccessModifierOffset in clang-format Dec 20, 2023
@GeckoEidechse
Copy link
Member

Merging with 2 in favour (@ASpoonPlaysGames @p0358) and 1 slightly (but not fully) opposed (@Jan200101)

I asked for feedback on the #development on the Northstar Discord multiple times and this is all I got so I assume the remaining contributors are indifferent on the change.

@GeckoEidechse GeckoEidechse removed needs code review Changes from PR still need to be reviewed in code feedback wanted Feedback is wanted whether the changes by this PR are desired labels Dec 20, 2023
@GeckoEidechse GeckoEidechse merged commit 714282b into R2Northstar:main Dec 20, 2023
1 of 2 checks passed
uniboi pushed a commit to uniboi/NorthstarLauncher that referenced this pull request Dec 21, 2023
Default appears to be -2, which causes clang-format to mix tabs and spaces
@ASpoonPlaysGames ASpoonPlaysGames deleted the access-modifier-offset branch January 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants