Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of Autohook from languagehooks.cpp #787

Merged

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Make sure that the logging in the language hooks still triggers and behaves normally.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 27, 2024
@GeckoEidechse
Copy link
Member

Not sure how to test this cause I cannot even get current main to switch the language when setting the game to German in Steam and then using either -lanuage=english or -lanuage english...

What do you think would be the best way to proceed?

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to code look good 🐰

@F1F7Y
Copy link
Member

F1F7Y commented Aug 30, 2024

Not sure how to test this cause I cannot even get current main to switch the language when setting the game to German in Steam and then using either -lanuage=english or -lanuage english...

What do you think would be the best way to proceed?

Merge it and make a tracking issue or bother someone who can step through the code :)

@GeckoEidechse GeckoEidechse removed the needs code review Changes from PR still need to be reviewed in code label Aug 31, 2024
@GeckoEidechse
Copy link
Member

Made issue via #778

I guess we just YOLO this one otherwise. Like ideally we'd fix the hook first and then replace the macro as it should be easier to bisect the change that broke it in this case. That being said, I also don't wanna stall the process of removing the autohook macro so I'm merging despite not having a way to verify in testing that the change is correct.

@GeckoEidechse GeckoEidechse merged commit cb62662 into R2Northstar:main Aug 31, 2024
4 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/languagehooks.cpp branch September 5, 2024 12:51
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
…#787)

Removes AUTOHOOK macro from `languagehooks.cpp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing Changes from the PR still need to be tested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants