-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of Autohook from languagehooks.cpp
#787
Remove uses of Autohook from languagehooks.cpp
#787
Conversation
Not sure how to test this cause I cannot even get current main to switch the language when setting the game to German in Steam and then using either What do you think would be the best way to proceed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to code look good 🐰
Merge it and make a tracking issue or bother someone who can step through the code :) |
Made issue via #778 I guess we just YOLO this one otherwise. Like ideally we'd fix the hook first and then replace the macro as it should be easier to bisect the change that broke it in this case. That being said, I also don't wanna stall the process of removing the autohook macro so I'm merging despite not having a way to verify in testing that the change is correct. |
…#787) Removes AUTOHOOK macro from `languagehooks.cpp`.
Code review:
o_p
so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.h_
so any times where we would be wanting to call the hooked function from other functions should now be calling that insteadTesting: