Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of Autohook from filesystem.cpp #795

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Remove uses of Autohook from filesystem.cpp #795

merged 8 commits into from
Aug 30, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Make sure that the loading mod files (scripts etc.) works as normal

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 30, 2024
F1F7Y
F1F7Y approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code👍

@F1F7Y F1F7Y added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs code review Changes from PR still need to be reviewed in code labels Aug 30, 2024
GeckoEidechse
GeckoEidechse reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

As can be seen from the screenshot mod file (bik video in this case) was still loaded
image

GeckoEidechse
GeckoEidechse approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(forgot to press approve in the review above)

@GeckoEidechse GeckoEidechse merged commit e73ede2 into R2Northstar:main Aug 30, 2024
4 checks passed
@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Aug 30, 2024
@GeckoEidechse GeckoEidechse mentioned this pull request Aug 31, 2024
Open
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/filesystem.cpp branch September 5, 2024 12:51
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
@ASpoonPlaysGames @wolf109909
core: Remove uses of Autohook from filesystem.cpp (R2Northstar#795)
5aadd2b 
Replace cases of autohook macro with manual hook calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F1F7Y F1F7Y F1F7Y approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @GeckoEidechse @F1F7Y