Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of Autohook from sourceinterface.cpp #798

Merged
merged 5 commits into from
Aug 31, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Make sure that CreateInterface <SERVER/CLIENT/ENGINE> still get logged
  • Make sure that the in-game console still exists (since InitialiseConsoleOnInterfaceCreation gets called from ClientCreateInterface)

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 31, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing:

[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VCvarQuery001
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VAvi001
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VBik001
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VENGINE_LAUNCHER_API_VERSION004
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VDataCache003
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VPrecacheSystem001

and
image

@GeckoEidechse GeckoEidechse added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Aug 31, 2024
@F1F7Y
Copy link
Member

F1F7Y commented Aug 31, 2024

Gotta say this file has no right to still be in this code base. Same with the SourceInterface class (copied from icepick btw), might PR later :)

Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@F1F7Y F1F7Y added READY TO MERGE This mergeable right now and removed needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Aug 31, 2024
@F1F7Y F1F7Y merged commit f2d07f5 into R2Northstar:main Aug 31, 2024
6 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/sourceinterface.cpp branch September 5, 2024 12:51
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
…#798)

Replaces the AUTOHOOK macro in `sourceinterface.cpp` with HookAttach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants