-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of Autohook from sourceinterface.cpp
#798
Remove uses of Autohook from sourceinterface.cpp
#798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working in testing:
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VCvarQuery001
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VAvi001
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VBik001
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VENGINE_LAUNCHER_API_VERSION004
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VDataCache003
[2024-08-31] [15:24:55] [NORTHSTAR] [info] CreateInterface ENGINE VPrecacheSystem001
Gotta say this file has no right to still be in this code base. Same with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
…#798) Replaces the AUTOHOOK macro in `sourceinterface.cpp` with HookAttach.
Code review:
o_p
so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.h_
so any times where we would be wanting to call the hooked function from other functions should now be calling that insteadTesting:
CreateInterface <SERVER/CLIENT/ENGINE>
still get loggedInitialiseConsoleOnInterfaceCreation
gets called fromClientCreateInterface
)