Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of Autohook from logging.cpp #811

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Remove uses of Autohook from logging.cpp #811

merged 2 commits into from
Sep 7, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • Check the file for anything that would depend on AUTOHOOK_INIT to run

Testing:

  • None needed? This was just an unused AUTOHOOK_INIT? I guess just make sure the game launches still?

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 4, 2024
GeckoEidechse
GeckoEidechse approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes unused AUTOHOOK_INIT() so not much to review here. Game still launches fine as expected ^^

@GeckoEidechse GeckoEidechse merged commit dab5764 into R2Northstar:main Sep 7, 2024
4 checks passed
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
@ASpoonPlaysGames @wolf109909
Remove uses of Autohook from logging.cpp (R2Northstar#811)
de9e392 
Remove AUTOHOOK_INIT
@ASpoonPlaysGames ASpoonPlaysGames deleted the autohook/logging.cpp branch September 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ASpoonPlaysGames @GeckoEidechse