-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of Autohook from loghooks.cpp
#812
Merged
GeckoEidechse
merged 9 commits into
R2Northstar:main
from
ASpoonPlaysGames:autohook/loghooks.cpp
Nov 20, 2024
Merged
Remove uses of Autohook from loghooks.cpp
#812
GeckoEidechse
merged 9 commits into
R2Northstar:main
from
ASpoonPlaysGames:autohook/loghooks.cpp
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
Changes from the PR still need to be tested
needs code review
Changes from PR still need to be reviewed in code
labels
Sep 4, 2024
F1F7Y
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
F1F7Y
approved these changes
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
RoyalBlue1
added
almost ready to merge
Apart from any small remaining other issues addressed by other labels, this would be ready to merge
and removed
needs testing
Changes from the PR still need to be tested
needs code review
Changes from PR still need to be reviewed in code
labels
Nov 19, 2024
Testing in prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
almost ready to merge
Apart from any small remaining other issues addressed by other labels, this would be ready to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review:
o_p
so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.h_
so any times where we would be wanting to call the hooked function from other functions should now be calling that insteadTesting:
spewlog_enable 1
is set)