Fastball related bugs and suggestions

[GeckoEidechse]

Based on playing a few Fastball matches in a competitive setting, here's a few things we noticed:

Bugs:

• The end of each round seems to have add a death to each player -> fixed with Hide death from scoreboard when playerDeathHidden is true #72
• Dropped guns are not always deleted between rounds (needs confirmation)
  On a round on Angel City I rushed B at the start of the round an noticed there was already a gun lying there on the floor, likely from the previous round
• Players seem to be spawned at the position of the hacker, not the panel (needs confirmation)
  When hacking B on Glitch I could killed right after hacking, making my camera fall through the floor (related to Dying as soon as you complete hacking a terminal on fastball sticks camera in floor #55). The majority of my spawned team mates then died due to falling in the river. This implies they were spawned on my current position instead of relative to the panel.
• Players going invis after respawn on Wargames
  Tracked in Players can go invisble on Fastball on Wargames #92
• Setting Boosts to disabled does not work.
  In other modes (tested CTF and PvP) boosts stay disabled but in Fastball it falls back to "Default"
• Fastball has no half time yet
  Maps and panel locations are not symmetric so there should be some form of half time where teams switch sides.
• When the last player of a team is killed right after hacking the panel, their team mates still respawn but the round ends.
  Either the team mates should not be allowed to respawn in the first place or the round should not end. The current situation of respawning but still losing is kinda confusing for the players respawning.
• Whatever fixed end of round survivors still receiving a death on the scoreboard when round ends, also introduced a bug where the last player killed doesn't receive a death either now.
• If round ends while a player is watching the kill replay of their own death, for them the killer on the end of round replay is shown as the same person as the one in the kill replay.
  In other words, the name at the bottom right corner in the replay is never updated if it transitions directly from kill replay to end of round replay.
• spectators in fastball respawn #615

Difficult to reproduce (= push back to later):

• One of the rounds we player had no kill cam replay.
• In a round on Glitch a player was invisible except for their gun. Approaching them crashed the game.
  Link to recording
  Note that I was using a dev build of NorthstarMods that is newer than v1.4.0 but known older than 686b3f8. I sadly cannot give the exact commit as downloaded the source as zip, so no .git folder to check :c

Suggestions

• On the scoreboard, instead of deaths, maybe display cumulative players respawned when hacking a panel

Minor / possibly competitive setting only:

• Option to reduce BT time and replay
  This was mentioned on the first game and might be better fitted for 3rd party mod anyway
• All deaths happening after the round ended should not count to the scoreboard
  E.g. someone just got the final kill and then they or a team mate die to for example a stray firestar or by falling down the river on Glitch, those kills should not show up in the scoreboard, either by making the players invincible in the period between round end and killcam replay or simply not counting deaths in that period.

 

(This addresses many points that are all for one specific mode, hence condensing it into one issue instead of multiple separate)

[abarichello]

I think the first checkpoint already got addressed here: #72

[Neoministein]

• On the scoreboard, instead of deaths, maybe display cumulative players respawned when hacking a panel

Totally agree, would make a lot of sense to see it.

[GeckoEidechse]

Added a few more points from today's session.

[BobTheBob9]

Players seem to be spawned at the position of the hacker, not the panel (needs confirmation)

should be fixed as of 050e707

[BobTheBob9]

Fastball has no half time yet

should be fixed as of 3e98aad

[GeckoEidechse]

050e707 has been reverted due to causing regressions (#169 #170).

[GeckoEidechse]

Added another bug to the list: The last player dying on a loosing team no longer receives a death either. Likely caused by the same commit that fixed surviving players always receiving a death at end of round.

[Bobbyperson]

Hey just wanted to add another bug here, very inconsistently players will respawn with their view in the floor. Other players can see them fine, but these players cannot wallrun or do any movement beyond sprinting (may need additional confirmation). Additionally, you can shoot your gun, but the bullets come out of where your eyes are and not your actual view. Attached is a video of this happening twice.

smallfloor.mp4

[GeckoEidechse]

Thanks for the report <3

What's interesting is that usually this would happen when the player hacking the panel dies at the time players are respawned. However this is clearly not the case in the first clip so really curious what's causing it then ^^"

[GeckoEidechse]

cc @Zanieon for #132 (comment) cause you're an absolute wizard when it comes to this sorta stuff ^^

[Zanieon]

cc @Zanieon for #132 (comment) cause you're an absolute wizard when it comes to this sorta stuff ^^

Judging by the video i can already foresee this problem being related to respawning code not setting up player settings properly and keeping them with spectator settings instead.

I have been doing some refactors of modular core gameplay scripts in my repos and i can take a look into this at some point, granted... if i didn't already fix it with said refactor lmao.

[Zanieon]

Took a quick look into Fastball code and i wanna die inside, i pretty much know exactly what causes the bug of respawning as a ground camera