Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Evac Visual and Sound #466

Merged
merged 8 commits into from Oct 21, 2022
Merged

Fixed Evac Visual and Sound #466

merged 8 commits into from Oct 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2022

Fix evac intro visual, flying sound and leaving visual

Fixed Evac Visual and Sound
fceec3b 
Fix evac intro visual, flying sound and leaving visual
@x3Karma
Copy link
Contributor

x3Karma commented Aug 1, 2022

Tested using Gecko's PR testing kit.

Works and there do be sound playing.
image

@x3Karma
Copy link
Contributor

x3Karma commented Aug 1, 2022 •
edited
Loading

Titanfall.2.Clips_1.mp4

@GeckoEidechse
Copy link
Member

Fix evac intro visual, flying sound and leaving visual

Just so I can check as well (and for documentation reasons), what is the issue with it currently? ^^

@GeckoEidechse GeckoEidechse added the needs code review Changes from PR still need to be reviewed in code label Aug 3, 2022
@x3Karma
Copy link
Contributor

x3Karma commented Aug 4, 2022

Just so I can check as well (and for documentation reasons), what is the issue with it currently? ^^

It was missing that blue light beam in the first screenshot I sent.

It was also very silent ( no jet noises at all ).

I think this PR fixes some visual changes, but those are harder to tell without comparison.

Hiding the dropship when it spawns is one of the changes here, as before there was a split second where you see the dropship at the arrival location before it switched to it's animation.

DBmaoha added 3 commits August 9, 2022 16:34
uniboi
uniboi approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good and cool

ASpoonPlaysGames
ASpoonPlaysGames requested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly good to me, just a couple of things that I would say need changing

Northstar.CustomServers/mod/scripts/vscripts/evac/_evac.gnut Show resolved Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/evac/_evac.gnut Outdated Show resolved Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/evac/_evac.gnut Outdated Show resolved Hide resolved
@x3Karma
Copy link
Contributor

x3Karma commented Aug 11, 2022

Spoon's requested changes were resolved with 7b1e727.

ASpoonPlaysGames
ASpoonPlaysGames approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good now as far as i'm concerned

F1F7Y
F1F7Y approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Erlite
Copy link
Contributor

Erlite commented Oct 21, 2022

Finally no more dropship teleporting across the entire map.

@BobTheBob9 BobTheBob9 merged commit a758993 into R2Northstar:main Oct 21, 2022
JMM889901 pushed a commit to JMM889901/NorthstarMods that referenced this pull request Aug 12, 2024
@JMM889901
Fixed Evac Visual and Sound (R2Northstar#466)
b9aa0d3 
* Fixed Evac Visual and Sound

Fix evac intro visual, flying sound and leaving visual

* Removed Unnecessary comments

Added better comments

* Added IsValid() Check

Added IsValid() check after a wait

* Added EndSignal and Default Situation for ShipSetting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@x3Karma @GeckoEidechse @Erlite @uniboi @F1F7Y @ASpoonPlaysGames @BobTheBob9