Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Music and Dialogue Event #469

Merged
merged 9 commits into from Oct 21, 2022
Merged

Added Music and Dialogue Event #469

merged 9 commits into from Oct 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2022

Added Music based on score event and time.
Added Dialogue event based on score comparation and after killing a player's titan.

Added Music and Dialogue Event
70bce01 
Added Music based on score event and time.
Added Dialogue event based on score comparation and after killing a player's titan
@x3Karma
Copy link
Contributor

x3Karma commented Aug 1, 2022

I'm not sure if _music.gnut is really needed as this would affect custom gamemodes which already uses cl_gamemode_xxxx.nut to define musics to be played.

@ghost
Copy link
Author

ghost commented Aug 1, 2022

Never thought about that, maybe we can save it only for those deathmatch gamemodes?

@x3Karma
Copy link
Contributor

x3Karma commented Aug 1, 2022

Never thought about that, maybe we can save it only for those deathmatch gamemodes?

Yeah, maybe change the "exclude gamemodes" into "include these gamemodes" instead for vanilla modes, since we can't/don't modify vanilla client code.

DBmaoha added 2 commits August 1, 2022 16:39
Changed Filter Type to Only DM Gamemodes
7b9c419 
Only vanilla gamemodes those have unlimited respawns will automatically plays music
Added a !
862aa3a 
omg
BobTheBob9
BobTheBob9 requested changes Aug 2, 2022
View reviewed changes
Copy link
Member

@BobTheBob9 BobTheBob9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't put these in a tempfix folder, music/dialogue for gamestate should be in mp/_gamestate_mp and dialogue for score events should be with the other score event code, any gamemode-specific stuff should be in the code for that gamemode

@ghost
Copy link
Author

ghost commented Aug 2, 2022

don't put these in a tempfix folder, music/dialogue for gamestate should be in mp/_gamestate_mp and dialogue for score events should be with the other score event code, any gamemode-specific stuff should be in the code for that gamemode

Got it, I'll move them

DBmaoha added 2 commits August 3, 2022 07:56
Removed Music Event
0248ffe 
Removed Music Event,  Moved Dialogue Event to _gamestate_mp.nut
Changed mods.json
65f93fd
@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 3, 2022
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell. Would maybe be nice to support >2 teams for the dialogue events, but I think that would be a separate PR

@ghost
Copy link
Author

ghost commented Oct 3, 2022

This looks good as far as I can tell. Would maybe be nice to support >2 teams for the dialogue events, but I think that would be a separate PR

once tried to make a ffa one but failed, I think I can try it again since I've learned some new things

@BobTheBob9 BobTheBob9 merged commit ee0613f into R2Northstar:main Oct 21, 2022
JMM889901 pushed a commit to JMM889901/NorthstarMods that referenced this pull request Aug 12, 2024
@JMM889901
Added Music and Dialogue Event (R2Northstar#469)
274f187 
* Added Music and Dialogue Event

Added Music based on score event and time.
Added Dialogue event based on score comparation and after killing a player's titan

* Changed Filter Type to Only DM Gamemodes

Only vanilla gamemodes those have unlimited respawns will automatically plays music

* Added a !

omg

* Removed Music Event

Removed Music Event,  Moved Dialogue Event to _gamestate_mp.nut

* Changed mods.json

* Changed RoundBased Gamemodes Check

not hardcoded right now

* Moved Killing Titan Dialogue to _score.nut

dialogue is now together with scoreevent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@x3Karma @BobTheBob9 @ASpoonPlaysGames @GeckoEidechse