Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Killer Outline #470

Merged
merged 3 commits into from Aug 2, 2022
Merged

Added Killer Outline #470

merged 3 commits into from Aug 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2022

Added killer outline: highlight the killer after being killed

Added Killer Outline
171d425 
Added killer outline: highlight the killer after being killed
@x3Karma
Copy link
Contributor

x3Karma commented Aug 1, 2022

For this PR, I think adding it to _base_gametype_mp.gnut is good enough.
image

Tested by adding it on line 302 of the file.

Changed to _base_gametype_mp.gnut
df1c68a 
Not using a single script right now
@ghost
Copy link
Author

ghost commented Aug 1, 2022 •
edited by ghost
Loading

For this PR, I think adding it to _base_gametype_mp.gnut is good enough. image

Tested by adding it on line 302 of the file.

will this be better? moved it to _base_gametype_mp.gnut

@x3Karma
Copy link
Contributor

x3Karma commented Aug 1, 2022 •
edited
Loading

will this be better? moved it to _base_gametype_mp.gnut

oh move it inside the if ( IsValid ( attacker ) ) check. Also remove the attacker.IsNPC(), NPCs don't have outline I'm pretty sure.

EDIT: https://www.youtube.com/watch?v=ZyBt8Jg5Vic&ab_channel=x3Karma, grunts doesn't have outline when killing a player.

@ghost
Copy link
Author

ghost commented Aug 1, 2022

will this be better? moved it to _base_gametype_mp.gnut

oh move it inside the if ( IsValid ( attacker ) ) check. Also remove the attacker.IsNPC(), NPCs don't have outline I'm pretty sure.

EDIT: https://www.youtube.com/watch?v=ZyBt8Jg5Vic&ab_channel=x3Karma, grunts doesn't have outline when killing a player.

got it

Removed IsNPC() Check
ba293d7 
Moved inside the if ( IsValid ( attacker ) ) check and removed the attacker.IsNPC()
@BobTheBob9
Copy link
Member

looks great, surprised i never saw this func

@BobTheBob9 BobTheBob9 merged commit f66c631 into R2Northstar:main Aug 2, 2022
GeckoEidechse pushed a commit that referenced this pull request Aug 7, 2022
@GeckoEidechse
Added Killer Outline (#470)
ef28763 
* Added Killer Outline

Added killer outline: highlight the killer after being killed

* Changed to _base_gametype_mp.gnut

Not using a single script right now

* Removed IsNPC() Check

Moved inside the if ( IsValid ( attacker ) ) check and removed the attacker.IsNPC()
JMM889901 pushed a commit to JMM889901/NorthstarMods that referenced this pull request Aug 12, 2024
@JMM889901
Added Killer Outline (R2Northstar#470)
56271d8 
* Added Killer Outline

Added killer outline: highlight the killer after being killed

* Changed to _base_gametype_mp.gnut

Not using a single script right now

* Removed IsNPC() Check

Moved inside the if ( IsValid ( attacker ) ) check and removed the attacker.IsNPC()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x3Karma @BobTheBob9 @ASpoonPlaysGames